190412 log를 기록하는 함수 생성#95
Merged
crongro merged 1 commit intocode-squad:Soorealbutnicefrom Apr 16, 2019
Merged
Conversation
Contributor
|
커밋로그에 날짜를 넣을 필요는 없습니다. 커밋정보에 이미 들어가 있어요 |
crongro
approved these changes
Apr 16, 2019
| let utils = require("./STEP2_2_utils") | ||
| let log = "<계산수행순서 > \n"; | ||
| let result = 0; | ||
| let logList = ["<계산 수행 순서> \n"]; |
Contributor
There was a problem hiding this comment.
데이터를 보관할때는 순수한 데이터를 보관하는 것이 좋아요.
그래야 데이터를 다양하게 활용할 수가 있겠죠.
그래서 loglist가 출력순서를 저장한다고 하여도, 출력용 메시지를 담는 건 좋지 않아보이네요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Michelle & 수리 step2-2 코드리뷰 반영