mukeunzi & Jin step4-1 수정사항 반영#85
Merged
crongro merged 13 commits intocode-squad:mukeunzifrom Apr 17, 2019
Merged
Conversation
mukeunzi
commented
Apr 17, 2019
- constructor 로직 제거
- customTodo 에서 todoCount로 변수명 변경
todo의 생성자함수로 makeNewTodo 대체
show(), printStatus()
printAll과 printStatus에 return을 넣어 log를 한번만 호출하게 구조변경
충돌을 머지로 해결
customTodo에서 todoCount로 변수명 변경
Contributor
|
축하해요! |
|
@nigayo @mukeunzi 충돌 해결 커밋했습니다! |
crongro
approved these changes
Apr 17, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
잘 수정했네요
사용한 메서드들에 대해서 잘 이해하도록 하세요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.