Skip to content

reduce page_size from py42 default (500) to 100 #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timabrmsn merged 4 commits into from
Jul 21, 2022
Merged

reduce page_size from py42 default (500) to 100 #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82b34ef
reduce page_size from py42 default (500) to 100
timabrmsn Jul 20, 2022
2ff9f7e
changelog
timabrmsn Jul 20, 2022
8833830
style
timabrmsn Jul 21, 2022
a05c7a8
bump version
timabrmsn Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
The intended audience of this file is for py42 consumers -- as such, changes that don't affect
how a consumer would use the library (e.g. adding unit tests, updating documentation, etc) are not captured here.

## 1.14.4 - 2022-07-21

### Changed

- Reduced the `page_size` in Device API calls from 500 to 100 to reduce possibility of timeouts when including backup usage in `code42 devices list`.

## 1.14.3 - 2022-07-06

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/code42cli/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.14.3"
__version__ = "1.14.4"
5 changes: 4 additions & 1 deletion src/code42cli/cmds/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,10 @@ def _get_device_dataframe(
sdk, columns, active=None, org_uid=None, include_backup_usage=False
):
devices_generator = sdk.devices.get_all(
active=active, include_backup_usage=include_backup_usage, org_uid=org_uid
active=active,
include_backup_usage=include_backup_usage,
org_uid=org_uid,
page_size=100,
)
devices_list = []
if include_backup_usage:
Expand Down