Merged
Conversation
Member
cmeissner
commented
Jan 4, 2021
- Fix unable to login with no clear error message. #38 - by updating exception handling and documentation
- add some project management stuff
As the try to connect to an unsecure api endpoint with user token leads to an exception we need to adapt our exception handling to print out the full and correct information. As `https` connections are industry standard we don't invest much effort in implementation of the `encryption` feature. If anybody needs this feature feel free to contribute or file a feature request where interested can vote on.
As phpIPAM does not support `User token` via `http` by default we need to adapt our documentation to reflect these fact.
lush
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.