Skip to content

Fixed sdk path (uppercase). #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
digitalnomad91 merged 1 commit into from
Feb 26, 2026
Merged

Fixed sdk path (uppercase). #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/local-android-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
- name: '🔍 Verify & Configure Android SDK'
run: |
# Force a fixed SDK location for the runner
ANDROID_HOME="/home/digitalnomad91/Android/sdk"
ANDROID_HOME="/home/digitalnomad91/Android/Sdk"

# Export for subsequent steps
echo "ANDROID_HOME=$ANDROID_HOME" >> $GITHUB_ENV
Comment on lines 114 to 118
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ANDROID_HOME is hard-coded to a specific user home path. This makes the workflow brittle on any self-hosted runner where the account/home directory differs (and it also changes behavior depending on whether the SDK dir is Sdk vs sdk). Prefer deriving from $HOME (e.g., $HOME/Android/Sdk) and/or using an existing ANDROID_SDK_ROOT/ANDROID_HOME if already set, with a fallback check for both common casings before failing.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:

- name: '🏗️ Build Release APK with Gradle'
run: |
export ANDROID_HOME="/home/digitalnomad91/Android/sdk"
export ANDROID_HOME="/home/digitalnomad91/Android/Sdk"
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step re-exports ANDROID_HOME with another hard-coded absolute path, which duplicates the earlier configuration and can silently drift if one location is changed later. Since ANDROID_HOME is already written to $GITHUB_ENV in the prior step, use that value here (or remove this line) to keep the workflow single-sourced.

Suggested change
export ANDROID_HOME="/home/digitalnomad91/Android/Sdk"

Copilot uses AI. Check for mistakes.
cd android
./gradlew clean assembleRelease \
-x bundleRelease \
Expand Down