Conversation
codecat
left a comment
There was a problem hiding this comment.
I haven't gone through the whole review yet (I'd like to try some of these changes myself), but a couple notes:
| [Setting category="Gamepad" name="Inactive alpha" drag min=0 max=1] | ||
| float Setting_Gamepad_OffAlpha = 0.33f; |
There was a problem hiding this comment.
I think this should have if="Setting_Gamepad_OffAlphaText"
There was a problem hiding this comment.
this setting isn't only used for text though, so hiding it when the user doesn't want to use it for text but does for other elements would be silly
| [Setting | ||
| category="Gamepad" | ||
| name="Steer percentage size" | ||
| drag min=2 max=40 | ||
| if="Setting_Gamepad_Style Uniform"] | ||
| int Setting_Gamepad_SteerPercentageSize = 16; |
There was a problem hiding this comment.
The removal of this will potentially break people's existing configurations. I agree with the name change, but we may want to wait with merging this until in Openplanet I have some kind of aliasing of previous setting name(s). Made an issue for this here: openplanet-nl/issues#818
There was a problem hiding this comment.
renamed setting back, can change it in the future once we have aliasing
There was a problem hiding this comment.
[SettingAlias] will be available starting from 1.25.6 (on edge now); I think we should include it in this PR.
Sorry it's probably still a bit of a large PR, but these are just the changes I made concerning text on the input display. Most changes are for consistency across modes (e.g. steer percentage), but some are for convenience (e.g. toggling the
%symbol).New settings:
Fixed: