This repository was archived by the owner on May 21, 2025. It is now read-only.
Merged
Conversation
hootener
approved these changes
Jan 22, 2019
hootener
left a comment
There was a problem hiding this comment.
@thomasrockhu I think this is fine, however it seems like the appveyor builds are failing. Is this something we care about still supporting?
If we do, I'd try to patch it up and get it working again. If not, then remove the checks and merge this.
blueyed
reviewed
Jan 25, 2019
| ddt | ||
| mock | ||
| pytest | ||
| pytest>=3.6.0 |
Contributor
There was a problem hiding this comment.
This does not pin it to max, but requires a min..?!
However, pytest-cov should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are failing on
travisdue to pulling older versions ofpytestandcoverage. This PR pins them to minimumsPTAL @hootener