Merged
Conversation
itai-codefresh
suggested changes
Mar 14, 2019
| const json = await sdk.workflows.get({ id: workflowId }); | ||
| const workflowInstance = Workflow.fromResponse(json); | ||
| switch (workflowInstance.getStatus()) { | ||
| case 'success': |
| const { sdk } = require('../../../logic'); | ||
| const Workflow = require('../../../logic/entities/Workflow'); | ||
|
|
||
| const FIFTEEN_MINUTES = 15 * 60 * 1000; |
Contributor
There was a problem hiding this comment.
the naming is not good.
lets just use interval and total max retries
Contributor
There was a problem hiding this comment.
consider using standard retry npm module
https://github.com/tim-kos/node-retry
| return; | ||
| } | ||
| console.log(`Current build status is: '${_.upperCase(currentStatus)}'`); | ||
| consecutiveErrors = 0; // eslint-disable-line |
Contributor
There was a problem hiding this comment.
you are overriding this every time again to 0.
| throw e; | ||
| } | ||
| consecutiveErrors = (consecutiveErrors || 0) + 1; // eslint-disable-line | ||
| if (consecutiveErrors > FIFTEEN_MINUTES / interval) { |
Contributor
There was a problem hiding this comment.
just use retry npm module. it's super confusing
itai-codefresh
approved these changes
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.