Skip to content

feat: productionize workspace sandboxing and GitHub PR flows#5

Draft
roninjin10 wants to merge 6 commits intomainfrom
feat/bwrap-workspace-pr-flow
Draft

feat: productionize workspace sandboxing and GitHub PR flows#5
roninjin10 wants to merge 6 commits intomainfrom
feat/bwrap-workspace-pr-flow

Conversation

@roninjin10
Copy link
Copy Markdown
Contributor

@roninjin10 roninjin10 commented Apr 8, 2026

Summary

  • add bubblewrap-aware JJHub workspace attach support, plus visible sandbox controls in the Workspaces view so attach mode can cycle between auto, bwrap-required, and off
  • add a dedicated GitHub Pull Requests view in the TUI with list/detail rendering, draft PR creation, PR comments, dashboard discoverability, and command-palette navigation
  • harden GitHub PR automation by deriving the target repository from the origin remote and surfacing actionable errors for broken refs/jj/keep git failures

Test plan

  • go test ./internal/github ./internal/ui/views ./internal/ui/dialog ./internal/jjhub
  • go build .

@roninjin10
Copy link
Copy Markdown
Contributor Author

Tested via tmux in a dedicated worktree. The branch pushed successfully, but PR creation inside the Codeplane TUI hit a git fetch failure caused by a broken refs/jj/keep object in the shared repo; after deleting the invalid ref, the PR existed and could be inspected normally.

I also verified the landing-request path is still JJHub-specific: the Landings view supports create/review/comment/land interactions, but this repo currently has no GitHub PR landing integration and no open landing requests to exercise end-to-end from the UI.

@roninjin10
Copy link
Copy Markdown
Contributor Author

UX polish notes from exercising the flow:\n- workspace attach now has the right tmux persistence model, but it still needs a surfaced UI affordance for sandbox mode selection/status (auto vs required vs off)\n- the PR flow should handle git/jj ref corruption more gracefully and explain the remediation inline instead of failing during fetch\n- GitHub automation is still missing first-class TUI support for PR creation/comments/landing parity, so the current feature set is backend-only and should be wired into the Smithers/Codeplane views\n- landing requests are polished on the JJHub side, but there is still no equivalent GitHub-backed landing/merge request flow in the UI

@roninjin10
Copy link
Copy Markdown
Contributor Author

Follow-up productionization pass:

  • added a dedicated GitHub Pull Requests view in the TUI with list/detail rendering, draft PR creation, PR comments, and command-palette navigation
  • added visible sandbox controls to the Workspaces view so attach behavior can cycle between auto, bwrap-required, and off
  • hardened GitHub PR creation helpers to derive the target repo from the origin remote instead of local gh context, and added actionable handling for broken refs/jj/keep git failures

Validation run for this pass:

  • go test ./internal/github ./internal/ui/views ./internal/ui/dialog ./internal/jjhub
  • go build .

@roninjin10 roninjin10 changed the title feat: add bubblewrap workspace support and GitHub PR helpers feat: productionize workspace sandboxing and GitHub PR flows Apr 9, 2026
@roninjin10
Copy link
Copy Markdown
Contributor Author

Latest update pushed in 14e7221b:

  • surfaced Pull Requests directly in the dashboard for faster discovery
  • made the PR view consistently use the origin remote repo for creation flows
  • revalidated the PR view in tmux after the repo-targeting fix

This branch is clean and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant