feat: productionize workspace sandboxing and GitHub PR flows#5
feat: productionize workspace sandboxing and GitHub PR flows#5roninjin10 wants to merge 6 commits intomainfrom
Conversation
|
Tested via tmux in a dedicated worktree. The branch pushed successfully, but PR creation inside the Codeplane TUI hit a git fetch failure caused by a broken refs/jj/keep object in the shared repo; after deleting the invalid ref, the PR existed and could be inspected normally. I also verified the landing-request path is still JJHub-specific: the Landings view supports create/review/comment/land interactions, but this repo currently has no GitHub PR landing integration and no open landing requests to exercise end-to-end from the UI. |
|
UX polish notes from exercising the flow:\n- workspace attach now has the right tmux persistence model, but it still needs a surfaced UI affordance for sandbox mode selection/status (auto vs required vs off)\n- the PR flow should handle git/jj ref corruption more gracefully and explain the remediation inline instead of failing during fetch\n- GitHub automation is still missing first-class TUI support for PR creation/comments/landing parity, so the current feature set is backend-only and should be wired into the Smithers/Codeplane views\n- landing requests are polished on the JJHub side, but there is still no equivalent GitHub-backed landing/merge request flow in the UI |
|
Follow-up productionization pass:
Validation run for this pass:
|
|
Latest update pushed in
This branch is clean and pushed. |
Summary
Test plan