feat: add provider_name column to aibridge interceptions#23960
Merged
ssncferreira merged 2 commits intomainfrom Apr 2, 2026
Merged
feat: add provider_name column to aibridge interceptions#23960ssncferreira merged 2 commits intomainfrom
ssncferreira merged 2 commits intomainfrom
Conversation
dannykopping
reviewed
Apr 2, 2026
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
Looks good but needs a test please to validate that the recorded value is actually inserted into the db.
pawbana
reviewed
Apr 2, 2026
| COMMENT ON COLUMN aibridge_interceptions.provider_name IS 'The provider instance name which may differ from provider when multiple instances of the same provider type exist.'; | ||
|
|
||
| -- Backfill existing records with the provider type as the provider name. | ||
| UPDATE aibridge_interceptions SET provider_name = provider WHERE provider_name = ''; |
Contributor
There was a problem hiding this comment.
nit: I think WHERE clause is not needed.
Contributor
Author
There was a problem hiding this comment.
As discussed internally, this is not needed, but keeping this as an extra safety measure.
b06cd80 to
65f14c1
Compare
pawbana
approved these changes
Apr 2, 2026
65f14c1 to
96cd2b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
provider_nameto aibridge interceptions to store the provider instance name alongside the provider type. This allows distinguishing between multiple instances of the same provider type (e.g.copilotvscopilot-business).Changes
provider_namecolumn toaibridge_interceptionstable with backfill fromprovider.provider_namefield to the protoRecordInterceptionRequestmessage.ProviderNameto thecodersdk.AIBridgeInterceptionAPI response.Disclaimer: initially produced by Claude Opus 4.6, modified and reviewed by @ssncferreira .