Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Added tar.gz support for folder upload.#31

Open
AdallomRoy wants to merge 3 commits intocoderanger:masterfrom
AdallomRoy:master
Open

Added tar.gz support for folder upload.#31
AdallomRoy wants to merge 3 commits intocoderanger:masterfrom
AdallomRoy:master

Conversation

@AdallomRoy
Copy link
Copy Markdown

When first uploading files (no directory @ remote), it's MUCH more efficient to tar.gz files @ local, upload the archive and unzip it @ the remote.
For comparison, some 170 seconds uploads cut down to 1-2 seconds during my tests. (more than x100)
It still falls back to using parallel upload for single files or if it fails in one of the steps.

@coderanger
Copy link
Copy Markdown
Owner

How does this compare to rsync and what kind of latency is there on your connection?

@AdallomRoy
Copy link
Copy Markdown
Author

Hi,

I haven't compared it to rsync, since rsync is required to be installed @ the remote, while I'm using the base Azure Linux image and it's not installed there (as opposed to tar which comes with the basic Linux image), so it's irrelevant for me.
I'm located in Israel, and running azurerm on West Europe - that's the main cause for the latency. I guess if I were running a local vagrant things would look differently.
As for the exact latency, this is an example ping result:
Reply from XXXXXX: bytes=32 time=75ms TTL=48

Roy.

@amontalban
Copy link
Copy Markdown

Would love to have this merged, +1

@AdallomRoy
Copy link
Copy Markdown
Author

Hi @coderanger,
Are you going to accept this patch?
Do you have anything that should be fixed, or comments regarding it?

Thanks

@moshezvi
Copy link
Copy Markdown

Any update on this?

@AdallomRoy
Copy link
Copy Markdown
Author

@coderanger ?

1 similar comment
@AdallomRoy
Copy link
Copy Markdown
Author

@coderanger ?

@AdallomRoy
Copy link
Copy Markdown
Author

@coderanger ??????

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants