Conversation
After compiling, if ctest is enabled, one can simply run: > cd build/ > ctest And all tests will be run. CTest runs the same tests as the autoconf version except for the archived models (under `src/network-workloads/archived/`), which are not compiled by CMake.
To test the changes, I've used the synthetic ping pong example, which has been modified to allow for a more random pattern. Printing to screen the delay of each packet is a temporal change.
Previously, the latency (delay) of the packet was assumed to be the latency of the last chunk to arrive at the destination terminal. This is wrong. We must store the time at which the first chunk is sent and the time at which the last chunk is received. This change paves the way to implement a strategy to feed a predictor with latencies in the order in which the packets where sent (not delievered).
`g_is_surrogate_on` turns on or off the behaviour. When off, the simulation runs as usual. When it is on, packages are sent directly to the terminal destination skipping the network completely
- This needs ROSS commit 178e3c0 - The director is a function that it's called at GVT by ROSS - Average latency predictor implemented
Now we can configure the surrogate via the config .conf file. All workloads using dragonfly-dally have access to the surrogate now!
…odel-net by a workload
This requires the introduction of zombie events which inform the terminals of what packets to ignore but to keep simulating their behaviour anyway.
This is buggy. With some models this will work, with others it will definetely not. The problem resides on model-net's complexity. Knowing when to trigger the "next event" event is dependent on the state of model-net and its future messages already in the queue (the most important of which is the workload's new event)
ROSS version 557e0d4
…dler and into commit
…t, to work properly
…ezing of the network
Conflicts: src/networks/model-net/dragonfly-dally.C
…ge_list with terminals
…network if needed
…ke a different name The idea of this change is to be able to have a configuration file like: ``` 20 milc1 1 0 15 conceptual-jacobi3d-5 1 0 ``` While the workload_json_files allow us to tell CODES where to look for the json configuration files: ``` milc1 path-to/milc1.json conceptual-jacobi3d-5 path-to/my-conceptual-jacobi3d.json ```
Replaced fscanf loop with fgets/sscanf to handle trailing newlines consistently across systems (this bug was silently showing up in the GHC200 system). Also added error reporting for malformed lines. btw, this code was written by Claude and audited by me ;)
This merge brings three major changes: - The hardening of the reverse handlers and thus the removal of all non-determinism - The full implementation of an application director for mpi-replay, so that simulations can be accelerated - The connection of the old network surrogate to the application surrogate
Autoconf is now far too outdated and keeping it on synch with the changes made in the CMakefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new version comes with: