Fix for ScalaJS tests issue #601#706
Merged
lefou merged 6 commits intocom-lihaoyi:masterfrom Dec 5, 2019
Merged
Conversation
Contributor
Author
|
This addresses issue #601 |
Member
|
@javaduke this seems to have broken some of the existing tests. Do you think you could help investigate the travis failures? |
Contributor
Author
I fixed the issue but now travis fails with some weird error, not sure how to fix it... |
Member
|
@javaduke can you try rebasing and squashing your commits on top of the latest master? This is a travis bug and squashing normally makes it go away |
Use explicitly given Evaluator instance for evaluation (com-lihaoyi#702)
Contributor
Author
|
Yay, that did the trick, Travis works now. The Appveyor still fails though, do you know how to fix it? |
lihaoyi
reviewed
Oct 18, 2019
Member
|
one more comment. Just ignore appveyor for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.