Fix to Display Width Tests#278
Merged
ericnewton76 merged 1 commit intocommandlineparser:developfrom May 11, 2018
Merged
Conversation
… your Maximum Display Width is 80
ericnewton76
approved these changes
May 11, 2018
Member
ericnewton76
left a comment
There was a problem hiding this comment.
This looks good. I've run into this problem before with the tests and display width being different on my machine, vs appveyor, and another user found out that running inside a default docker container would get different results as well.
|
I did some testing - looks like this issue actually got fixed a while back. It works as of 2.4 and later. Fails on 2.3 and earlier with exception System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'value') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly passing MaximumDisplayWidth = 80 to tests that fail unless your Maximum Display Width is 80