Resolving the build error in the master branch#437
Merged
moh-hassan merged 3 commits intocommandlineparser:masterfrom Apr 26, 2019
moh-hassan:master-revert
Merged
Resolving the build error in the master branch#437moh-hassan merged 3 commits intocommandlineparser:masterfrom moh-hassan:master-revert
moh-hassan merged 3 commits intocommandlineparser:masterfrom
moh-hassan:master-revert
Conversation
Collaborator
Author
|
@ericnewton76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a build (compilation) error when cloning the project or merging PR (last commit: 030eb8d)
The problem was initially reported by @ebjornset
The problem is in the upstream previous merge commits (5343c5d)
This PR revert the two commits that causing the build error (6d2dc12 and 5343c5d) instead of reset to keep the master branch history.