Allow BaseAttribute HelpText localization to use internal classes and properties.#478
Closed
ILMTitan wants to merge 1 commit intocommandlineparser:developfrom
Closed
Allow BaseAttribute HelpText localization to use internal classes and properties.#478ILMTitan wants to merge 1 commit intocommandlineparser:developfrom
ILMTitan wants to merge 1 commit intocommandlineparser:developfrom
Conversation
Collaborator
|
Thanks @ILMTitan for your effort. Localization in .NET is based on public (not internal) resources. For example, in because:
For these reasons, localization in PR #356 check for visibility and fire exception for internal resources . I know, in VS IDE by default, resources are internal, but this can be modified easily. Is there any problems in using public resources? |
Author
|
Moving discussion to issue #477. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477.