Removed useless testing code#568
Merged
moh-hassan merged 1 commit intocommandlineparser:masterfrom Feb 3, 2020
Merged
Conversation
pergardebrink
pushed a commit
to pergardebrink/commandline
that referenced
this pull request
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed test is not marked for execution and was done when I had little understanding of properties testing.
Now I'm perfectly able to doing it in proper way :), as done e.g. in this two projects:
https://github.com/gsscoder/csharpx
https://github.com/gsscoder/sharprhythm
Anyway when I add
FsCheck.Xunitto test project (without any other change) a lot tests get broken!I'll do further investigation for this strange thing... For now better remove useless code even from test codebase.