Skip to content

chore: Add 'correct' to list of imperatives#382

Merged
shenxianpeng merged 3 commits intomainfrom
shenxianpeng-patch-1
Mar 16, 2026
Merged

chore: Add 'correct' to list of imperatives#382
shenxianpeng merged 3 commits intomainfrom
shenxianpeng-patch-1

Conversation

@shenxianpeng
Copy link
Member

@shenxianpeng shenxianpeng commented Mar 16, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated accepted commit message imperative verbs: "correctcount" is now allowed, and "count" is no longer accepted.

@shenxianpeng shenxianpeng requested a review from a team as a code owner March 16, 2026 18:44
@netlify
Copy link

netlify bot commented Mar 16, 2026 •
edited
Loading

✅ Deploy Preview for commit-check ready!

Name Link
🔨 Latest commit ccccf7f
🔍 Latest deploy log https://app.netlify.com/projects/commit-check/deploys/69b8531e3087a20008906ee1
😎 Deploy Preview https://deploy-preview-382--commit-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026 •
edited
Loading

Warning

Rate limit exceeded

@shenxianpeng has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 55 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 103fc809-6c64-4655-8322-e60902659140

📥 Commits

Reviewing files that changed from the base of the PR and between fa1a296 and ccccf7f.

📒 Files selected for processing (1)
  • commit_check/imperatives.py
📝 Walkthrough

Walkthrough

A single-line change to the IMPERATIVES set in commit_check/imperatives.py, replacing the imperative verb "count" with "correctcount" to modify the allowed verbs for commit message validation.

Changes

Cohort / File(s) Summary
Imperative Verbs Update
commit_check/imperatives.py		 Replaced "count" with "correctcount" in the IMPERATIVES set, altering the allowed imperative verbs for commit message validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hop from count to correctcount we take,
Imperatives mended, for validation's sake,
One string swapped with care so fine,
Commit messages now align! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions adding 'correct' but the changes show 'count' was replaced with 'correctcount', which is a different operation than what the title describes. Update the title to accurately reflect the change, such as 'chore: Replace count with correctcount in IMPERATIVES' or clarify the actual intent of the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shenxianpeng-patch-1
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shenxianpeng shenxianpeng added the enhancement New feature or request label Mar 16, 2026
coderabbitai[bot]
coderabbitai bot reviewed Mar 16, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@commit_check/imperatives.py`:
- Line 49: The token "correctcount" in the imperatives list is an accidental
concatenation; open the imperatives.py list where the string "correctcount"
appears and replace it with two separate imperative verbs "correct" and "count"
(i.e., remove "correctcount" and add "correct" and "count" entries) so the
subject validator sees the intended verbs.
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbeef2c5-5dfc-4e32-aa53-2873541bde8e

📥 Commits

Reviewing files that changed from the base of the PR and between 91b688c and fa1a296.

📒 Files selected for processing (1)
  • commit_check/imperatives.py

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2026 •
edited
Loading

Merging this PR will degrade performance by 37.56%

❌ 1 regressed benchmark
✅ 169 untouched benchmarks
⏩ 108 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_main_with_message_empty_string_no_stdin_with_git 5.1 ms 8.2 ms -37.56%

Comparing shenxianpeng-patch-1 (ccccf7f) with main (91b688c)

Open in CodSpeed

Footnotes

  1. 108 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shenxianpeng shenxianpeng merged commit 5e3a210 into main Mar 16, 2026
15 of 17 checks passed
@shenxianpeng shenxianpeng deleted the shenxianpeng-patch-1 branch March 16, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shenxianpeng