Skip to content

Add Docker-Compose, AWS & Upgrade Node, Java#8

Merged
jonnyelliot merged 15 commits intomasterfrom
je-update
Mar 12, 2020
Merged

Add Docker-Compose, AWS & Upgrade Node, Java#8
jonnyelliot merged 15 commits intomasterfrom
je-update

Conversation

@jonnyelliot
Copy link
Copy Markdown
Contributor

@jonnyelliot jonnyelliot commented Mar 12, 2020 •
edited
Loading

  • Updates base image to use AdoptOpenJDK 13 Ubuntu
  • Adds Docker Compose tool
  • Adds AWS CLI tool
  • Adds drone build to ease building/testing changes
  • Updates Node to latest LTS
  • Updates README to include pinned tool versions, adds licence references
  • Updates CI tests to include all tools

Closes #6
Closes #7

stuarthendren
stuarthendren reviewed Mar 12, 2020
View reviewed changes
stuarthendren
stuarthendren requested changes Mar 12, 2020
View reviewed changes
README.md

The build tools included are:

- **Java** openjdk 11.0.2 2019-01-15
Copy link
Copy Markdown
Contributor

@stuarthendren stuarthendren Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change to latest?

Would soon be wrong

Copy link
Copy Markdown
Contributor Author

@jonnyelliot jonnyelliot Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest is the wrong word I agree. I just mean that the versions arent pinned (will update whenever the image is rebuilt)

Copy link
Copy Markdown
Contributor Author

@jonnyelliot jonnyelliot Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to update all the versions here but I know they'd become out of date before long

Copy link
Copy Markdown
Contributor Author

@jonnyelliot jonnyelliot Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now removed the "latest" wording entirely for unpinned stuff

Copy link
Copy Markdown
Contributor

@stuarthendren stuarthendren Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems like the wrong thing to be doing you don't want your tools changing from one ci build to the next.

Should fix the base version then they would be pinned.

The tests could be extended to print all these version to make it easier to update.

stuarthendren
stuarthendren requested changes Mar 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stuarthendren stuarthendren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the base image version

@jonnyelliot
Copy link
Copy Markdown
Contributor Author

jonnyelliot commented Mar 12, 2020

@stuarthendren I've fixed the base image version and now list all versions out in the README.

@jonnyelliot jonnyelliot merged commit 1aa7a1f into master Mar 12, 2020
@jonnyelliot jonnyelliot deleted the je-update branch March 12, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuarthendren stuarthendren stuarthendren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add aws cli Install docker-compose

2 participants

@jonnyelliot @stuarthendren