Skip to content
This repository was archived by the owner on Jun 29, 2021. It is now read-only.

Version 2.0.0#7

Merged
stuarthendren merged 35 commits intomasterfrom
je-improvements2
May 10, 2020
Merged

Version 2.0.0#7
stuarthendren merged 35 commits intomasterfrom
je-improvements2

Conversation

@jonnyelliot
Copy link
Copy Markdown
Contributor

  • Adds NavListItem component to support closing of the nav drawer when an item is clicked
  • Updates project boilerplate, recreated using a clean template of tsdx. Updating dependencies, tsconfig, etc.
    • Use the same @material-ui/core version as components (4.9.10)
  • Adds storybook, using the react-with-storybook tsdx template
    • Adds a story using knobs addon to tryout different LayoutConfig props
    • Adds a story demonstrating breakpoints
  • (Breaking change) Removes hard dependency on @committed/components to workaround dependency issues. No dependency on icons either. Icons must now be passed as props.
  • Adds an improved example app
  • Document prop changes in README
  • Version bump to 2.0.0

- Adds NavListItem component to support closing of the nav drawer when an item is clicked
- Updates project boilerplate, recreated using a clean template of tsdx. Updating dependencies, tsconfig, etc.
    - Use the same @material-ui/core version as components (4.9.10)
- Adds storybook, using the react-with-storybook tsdx template
    - Adds a story using knobs addon to tryout different LayoutConfig props
    - Adds a story demonstrating breakpoints
- (Breaking change) Removes hard dependency on @committed/components to workaround dependency issues. No dependency on icons either. Icons must now be passed as props.
- Adds an improved example app
- Document prop changes in README
- Version bump to 2.0.0
@jonnyelliot jonnyelliot requested a review from stuarthendren May 2, 2020 19:20
moves defualt layout function to root, as only used there.
Required for ts 3.8 formatting
Now correctly finds the screen value when starting with sx
Use compoennts in layouts
Brings back the icons and renames the oicon props
Adds into page, theme and more stories
removes unused addons
Just goes direct to context but slightly nicer than
the useContext
Add more docs for components and props
when collapsed, removes test adds title and tris to make the same size.
This removes the scrolbar when collapsed.
Adds component stories
Separates examples
Adds a themed switch example to check light and dark
References storybook, removes props
Pull current nav width to context as computed lots.
Separate each component into two, a dumb with no layout
knowledge and the main, which adds the layout knowledge.
This aims to separate the concerns and allow
simpler testing of the loging and components.
local decorator doesnt work,
adds knob to squeezed
Fixes the basic case when toolbar not extended
Better respect right left swap
Swap icon accordingly
Separates the response of Header, Content and Footer.
Ignores navVariant, uses is responsible for making sensible choices.

Simplifies the behaviour.
@stuarthendren stuarthendren merged commit 5c65825 into master May 10, 2020
@stuarthendren stuarthendren deleted the je-improvements2 branch May 10, 2020 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants