This repository was archived by the owner on Jun 29, 2021. It is now read-only.
Merged
Conversation
Contributor
jonnyelliot
commented
May 2, 2020
- Adds NavListItem component to support closing of the nav drawer when an item is clicked
- Updates project boilerplate, recreated using a clean template of tsdx. Updating dependencies, tsconfig, etc.
- Use the same @material-ui/core version as components (4.9.10)
- Adds storybook, using the react-with-storybook tsdx template
- Adds a story using knobs addon to tryout different LayoutConfig props
- Adds a story demonstrating breakpoints
- (Breaking change) Removes hard dependency on @committed/components to workaround dependency issues. No dependency on icons either. Icons must now be passed as props.
- Adds an improved example app
- Document prop changes in README
- Version bump to 2.0.0
- Adds NavListItem component to support closing of the nav drawer when an item is clicked
- Updates project boilerplate, recreated using a clean template of tsdx. Updating dependencies, tsconfig, etc.
- Use the same @material-ui/core version as components (4.9.10)
- Adds storybook, using the react-with-storybook tsdx template
- Adds a story using knobs addon to tryout different LayoutConfig props
- Adds a story demonstrating breakpoints
- (Breaking change) Removes hard dependency on @committed/components to workaround dependency issues. No dependency on icons either. Icons must now be passed as props.
- Adds an improved example app
- Document prop changes in README
- Version bump to 2.0.0
moves defualt layout function to root, as only used there.
Required for ts 3.8 formatting
Now correctly finds the screen value when starting with sx
Use compoennts in layouts Brings back the icons and renames the oicon props
Adds into page, theme and more stories removes unused addons
Just goes direct to context but slightly nicer than the useContext
Add more docs for components and props
when collapsed, removes test adds title and tris to make the same size. This removes the scrolbar when collapsed.
Adds component stories Separates examples Adds a themed switch example to check light and dark
References storybook, removes props
Pull current nav width to context as computed lots. Separate each component into two, a dumb with no layout knowledge and the main, which adds the layout knowledge. This aims to separate the concerns and allow simpler testing of the loging and components.
local decorator doesnt work, adds knob to squeezed
Fixes the basic case when toolbar not extended
Better respect right left swap Swap icon accordingly
Separates the response of Header, Content and Footer. Ignores navVariant, uses is responsible for making sensible choices. Simplifies the behaviour.
stuarthendren
approved these changes
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.