Merged
Conversation
bmonkman
reviewed
Sep 3, 2020
modules/sendgrid/variables.tf
Outdated
| } | ||
|
|
||
| variable "cname" { | ||
| description = "list of CNAME records to be created for domain authentication" |
Contributor
There was a problem hiding this comment.
Maybe indicate here what the two values are in the tuple? (cname, target)
bmonkman
reviewed
Sep 3, 2020
bmonkman
reviewed
Sep 3, 2020
modules/sendgrid/README.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| # Sendgrid | |||
|
|
|||
| Authenticates domain with sendgrid, assumes CNAME required are provided in variables | |||
Contributor
There was a problem hiding this comment.
assumes CNAME required are provided in variables is redundant based on the rest of the docs.
bmonkman
reviewed
Sep 3, 2020
modules/sendgrid/README.md
Outdated
|
|
||
| <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK --> | ||
| ## Requirements | ||
| Assumes domain is already awaiting authentication, this created the route53 entries |
44b8488 to
bd194a0
Compare
bmonkman
reviewed
Sep 4, 2020
|
|
||
| ## Print our CNAMES for our target domain | ||
| ## IMPORTANT: must print out map[string]string in JSON format, where all values must be string(CANNOT be int/numbers/boolean) | ||
| JQ_CNAMES_QUERY=".[] | select( .domain == \"${DOMAIN}\" ) | { domain_id : .id|tostring } + (.dns | with_entries(.key |=\"\(.)_host\" | .value |=.host ) )+ (.dns | with_entries(.key |=\"\(.)_value\" | .value |=.data ) )" |
bmonkman
reviewed
Sep 4, 2020
modules/sendgrid/variables.tf
Outdated
| } | ||
|
|
||
| variable "sendgrid_api_key_secret_name" { | ||
| description = "api_key for sendgrid api, used to authenticate domain once route53 records are created" |
Contributor
There was a problem hiding this comment.
How about something like "name of the secret in AWS secret manager that contains the sendgrid API key"? Also could you please run the pre-commit hook so this stuff gets populated into the readme?
davidcheung
commented
Sep 4, 2020
| - jq | ||
| - curl No requirements. | ||
| - Api key to be stored in AWS secret manager | ||
| - HostedZone to be properly configured as root of domain in Route53 |
Contributor
Author
There was a problem hiding this comment.
should these be moved to ## Notes instead of requirements since theyre generated
Contributor
There was a problem hiding this comment.
Otherwise next time someone runs the pre-commit hook that will be wiped out.
bmonkman
approved these changes
Sep 4, 2020
Terraform Format and Style 🖌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commitdev/zero#263