add linting and validation to terraform code#108
Merged
davidcheung merged 4 commits intomainfrom Sep 25, 2020
Merged
Conversation
abca6b1 to
186cbf2
Compare
186cbf2 to
95ddff5
Compare
davidcheung
commented
Sep 25, 2020
| files: | ||
| dir: infrastructure | ||
| repo: github.com/commitdev-test/infrastructure | ||
| source: ../ |
Contributor
Author
There was a problem hiding this comment.
the ../ is kinda tricky, it is dependent on where you plan on copying the zero-project.yml
Contributor
Author
There was a problem hiding this comment.
another way is making the file a template zero-project.yml.tpl
then fill in with GITHUB_REF which would be the triggered branch
Contributor
|
Looks good! Maybe just needs a comment in the readme reminding people to keep the test fixture project yaml in sync? |
bmonkman
approved these changes
Sep 25, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
* add linting and validation to terraform code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR draft to trigger github actions