improvement: Use expose cf_signed_downloads to filter which buckets C…#119
Merged
GrooveStomp merged 3 commits intomainfrom Sep 30, 2020
Merged
improvement: Use expose cf_signed_downloads to filter which buckets C…#119GrooveStomp merged 3 commits intomainfrom
GrooveStomp merged 3 commits intomainfrom
Conversation
Contributor
|
Just a reminder that you'll need to bump the module version after that is merged. |
bmonkman
approved these changes
Sep 29, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
#119) * improvement: Use expose cf_signed_downloads to filter which buckets CI can access https://app.zenhub.com/workspaces/commit-zero-5da8decc7046a60001c6db44/issues/commitdev/zero/290 * Use renamed var name * Bump version of s3_hosting module to support new output var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…I can access
https://app.zenhub.com/workspaces/commit-zero-5da8decc7046a60001c6db44/issues/commitdev/zero/290