add new user - more commits with modules#99
Merged
Conversation
bmonkman
reviewed
Sep 18, 2020
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 24, 2020
| @@ -0,0 +1,111 @@ | |||
| # define AWS policy documents for developer | |||
| data "aws_iam_policy_document" "developer_access" { | |||
Contributor
There was a problem hiding this comment.
At some point we will want to revisit these policies, add stuff like enforcing MFA, etc. but this should be fine for now.
bmonkman
reviewed
Sep 24, 2020
| name = u.name | ||
| roles = [ | ||
| for r in u.roles : | ||
| r.name if contains(local.role_name_list, r.name) && contains(r.environments, var.environment) |
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 24, 2020
bmonkman
reviewed
Sep 25, 2020
|
|
||
| # EKS-Optimized AMI for your region: https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-ami.html | ||
| # https://<% index .Params `region` %>.console.aws.amazon.com/systems-manager/parameters/%252Faws%252Fservice%252Feks%252Foptimized-ami%252F1.17%252Famazon-linux-2%252Frecommended%252Fimage_id/description?region=<% index .Params `region` %> | ||
| # https://${local.region}.console.aws.amazon.com/systems-manager/parameters/%252Faws%252Fservice%252Feks%252Foptimized-ami%252F1.17%252Famazon-linux-2%252Frecommended%252Fimage_id/description?region=${local.region} |
Contributor
There was a problem hiding this comment.
This has to be templated in, it's in a comment.
bmonkman
reviewed
Sep 25, 2020
| module "eks" { | ||
| source = "commitdev/zero/aws//modules/eks" | ||
| version = "0.0.2" | ||
| version = "0.1.2" |
Contributor
There was a problem hiding this comment.
Could you please bump db and logging up to 0.1.2 as well?
bmonkman
approved these changes
Sep 25, 2020
bmonkman
added a commit
that referenced
this pull request
Oct 10, 2020
* initial commit, need check together with terraform-zero-modules/iam_users * fix with review * enhancement with map structure * enhancement with user group for AWS access * fix with template * enhancements with shared state and k8s rules etc. * refined modules-environemnt-root parameters etc. after review * Tweaked documentation a bit * remove unnecessary templating and use variables * replace space with tab * typo fix * recover templating for terraform block * typo comment fix * use remote modules and fixes * added tearndown steps for shared env * refer to newer versions of modules * add shared-remote-state generation Co-authored-by: Bill Monkman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with commitdev/terraform-aws-zero#6