Skip to content

fix: broken queue when more than 8k jobs exist with the same timestamp#1

Merged
compwright merged 1 commit intocompwright:masterfrom
Tob0t:fixTooManyValueToUnpack
Nov 21, 2022
Merged

fix: broken queue when more than 8k jobs exist with the same timestamp#1
compwright merged 1 commit intocompwright:masterfrom
Tob0t:fixTooManyValueToUnpack

Conversation

@compwright
Copy link
Copy Markdown
Owner

@compwright compwright commented Nov 21, 2022 •
edited
Loading

Copy of bee-queue#192 from @Tob0t:

Since there is no progress on bee-queue#123 I created another PR.

FYI: The commit from @mattbornski was taken.

Since our queues stopped working if there are more than 8k jobs with the same timestamp, we needed a fix asap. I know that the PR was not merged since there could be a further improvements. However as @mattbornski mentioned, better this fix with blocking redis for short time than processing no jobs at all.

We are already using this code on our production system since we needed a fix asap.

Disclaimer: I'm not a lua programmer, so feel free to adapt the PR ;)

@compwright
Copy link
Copy Markdown
Owner Author

compwright commented Nov 21, 2022

@Tob0t FYI I'm starting a maintained fork over here, would love to have any help you want to offer.

@compwright compwright added the bug Something isn't working label Nov 21, 2022
@compwright compwright changed the title fix unpacking too many values, taken from existing PR-#123 fix: broken queue when more than 8k jobs exist with the same timestamp Nov 21, 2022
@compwright compwright merged commit 52ece2f into compwright:master Nov 21, 2022
@compwright compwright mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@compwright