docs/CONTRIBUTING: rewrite & add commit guidelines#174
Merged
shaleman merged 1 commit intocontiv:masterfrom Nov 4, 2015
Merged
docs/CONTRIBUTING: rewrite & add commit guidelines#174shaleman merged 1 commit intocontiv:masterfrom
shaleman merged 1 commit intocontiv:masterfrom
Conversation
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
maybe instructions to git commit -s here?
Contributor
|
Looks great other than that nit |
Signed-off-by: Cristian Staretu <[email protected]>
86402f2 to
9d5b99a
Compare
Contributor
Author
|
The PR has been updated to make the following changes:
PTAL |
Contributor
|
LGTM |
shaleman
added a commit
that referenced
this pull request
Nov 4, 2015
docs/CONTRIBUTING: rewrite & add commit guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.