trim default tenant; fix policy bug#187
Merged
shaleman merged 1 commit intocontiv:masterfrom Nov 12, 2015
shaleman:service
Merged
trim default tenant; fix policy bug#187shaleman merged 1 commit intocontiv:masterfrom shaleman:service
shaleman merged 1 commit intocontiv:masterfrom
shaleman:service
Conversation
Contributor
shaleman
commented
Nov 11, 2015
- Trim default tenant name from docker network names
- Fix a bug in policy code
- Add mutexes around endpoint and address allocation
- Ugly hack to setup proxy interface
There was a problem hiding this comment.
should we use 'service.network/tenant' to avoid this confusion, then 'service.network' is valid and 'network/tenant' is valid and 'service.network/tenant' is valid too. This is assuming that '/' is allowed in the list as well.
Contributor
Author
There was a problem hiding this comment.
I haven't tried '/' character. We could try
shaleman
added a commit
that referenced
this pull request
Nov 12, 2015
trim default tenant; fix policy bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.