Merged
Conversation
Current coverage is 29.04% (diff: 9.63%)@@ master #1400 diff @@
==========================================
Files 137 137
Lines 12900 12943 +43
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3752 3759 +7
- Misses 8750 8786 +36
Partials 398 398
|
This brings PORT up to parity with SCHEME, PATH, USERNAME, and PASSWORD.
* If `LINK_PORT` not set, default to first port immediately * Return error if `LINK_PORT` can't be converted to integer * Return error if `LINK_PORT` set to non-existant port
* Imported package is back to `manifest` * Manifest arg to `resolveLinks` is now `m` * Pointer to manifest is now `mp`
Issue with newer docker versions if https is used via login causes push/pull commands to fail. Fixed slated for docker 1.13.0 - moby/moby#22910 - moby/moby#23100 (comment)
…create one with a generous delay
awsmsrc
approved these changes
Nov 17, 2016
Contributor
awsmsrc
left a comment
There was a problem hiding this comment.
this looks ok by eye (full disclosure i haven't ran this code)
Contributor
|
@MiguelMoll There's a doc update PR for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Requests
LINK_PORTvariable if it's set #1370 UseLINK_PORTvariable if it's set [@mwarkentin]Milestone Release