This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Add additional key for items of type array in order to make swagger spec valid#21
Merged
lovelydinosaur merged 1 commit intocore-api:masterfrom Oct 20, 2016
Merged
Conversation
lovelydinosaur
suggested changes
Oct 18, 2016
openapi_codec/encode.py
Outdated
| if field.type == 'array': | ||
| schema_property['items'] = {'type': 'string'} | ||
| else: | ||
| schema_property['type'] = 'string' |
Contributor
There was a problem hiding this comment.
Could be neater as...
...
'type': field.type or 'string' # Leave this as it currently is.
}
if field.type == 'array':
schema_property['items'] = {'type': 'string'}
That'd be a slightly more minimal change.
Otherwise looks good.
Author
There was a problem hiding this comment.
Ok, doing those changes now!, i'll update the pr
we will default to 'string' right now in order to make our swagger spec valid.
Author
|
@tomchristie is fixed, travis is failing because I missed the quotes .. I've done push + force on my branch but it seems travis doesn't play well with that, I think you can run travis manually anyway. |
Contributor
|
Build restarted. |
Author
|
@tomchristie seems ready to merge! |
lovelydinosaur
approved these changes
Oct 20, 2016
Contributor
|
Thanks @angvp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional key for items of type array with the type of each element we will default to 'string' right now in order to make our swagger spec
valid.
Closes #20