Open
Conversation
juliagallucci
approved these changes
May 7, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Good. Although, your code is quite complex. I would suggest making your functions as concise as possible. For example, part a could be written in 2 lines
def anagram_checker(word_a, word_b):
return sorted(word_a.lower()) == sorted(word_b.lower())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I write a program to check if two valid words are anagrams.
What did you learn from the changes you have made?
I learned how to process strings using variables, loops, control flow, and string methods.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I was thinking of using some other methods and data types.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
At first, I had to figure out how to check each character in each word. I overcame it by doing some research.
How were these changes tested?
They were tested on the cells.
A reference to a related issue in your repository (if applicable)
N/A
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist