CM-61568: Fix sensitive path skipping content scan and directory hand…#432
Merged
CM-61568: Fix sensitive path skipping content scan and directory hand…#432
Conversation
Collaborator
Ilanlido
commented
Apr 5, 2026
- Sensitive path in warn mode now scans file contents: Previously returned early without scanning, now falls through to content scan and emits separate events for the sensitive path finding and the scan result
- Directory paths no longer crash _scan_path_for_secrets: Changed os.path.exists() to os.path.isfile() so directories are rejected gracefully
- Added 5 new tests covering warn-mode sensitive path scenarios and directory handling
…ling In warn mode, sensitive paths returned early without scanning file contents for secrets. Now falls through to content scan and emits separate events for the sensitive path finding and the content scan result. Also fixes _scan_path_for_secrets failing on directories by using os.path.isfile(). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
gotbadger
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.