Fix default Solana token list and support transfer (not just transferChecked)#1286
Open
Fix default Solana token list and support transfer (not just transferChecked)#1286
transfer (not just transferChecked)#1286Conversation
337a24f to
c43b8fe
Compare
danrmiller
previously approved these changes
Apr 26, 2026
Collaborator
danrmiller
left a comment
There was a problem hiding this comment.
I think the token transaction parsing is missing the "innerInstructions" and those get missed.
I'm also not sure about the splTransfers.length != 1, I'm pretty sure that is going to miss things on multi-recipient transactions.
But those can be addresses seperately.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1286 +/- ##
========================================
Coverage 74.89% 74.89%
========================================
Files 11 11
Lines 685 685
========================================
Hits 513 513
Misses 172 172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a8726af to
c43b8fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.