Skip to content

remove --end-of-options option for git version < 2.24#82

Closed
mrsad wants to merge 2 commits intoczproject:masterfrom
mrsad:master
Closed

remove --end-of-options option for git version < 2.24#82
mrsad wants to merge 2 commits intoczproject:masterfrom
mrsad:master

Conversation

@mrsad
Copy link

@mrsad mrsad commented Oct 3, 2022

No description provided.

@janpecha
Copy link
Member

janpecha commented Oct 5, 2022

Hello,

I thought about it and I don't want this directly in CliRunner. What about new Runner implementation?

class OldGitRunner extends CliRunner
{
	public function run($cwd, array $args, array $env = NULL)
	{
		if (($key = array_search('--end-of-options', $args)) !== FALSE) {
			unset($args[$key]);
		}

		parent::run($cwd, $args, $env);
	}
}

$git = new CzProject\GitPhp\Git(new CzProject\GitPhp\Runners\OldGitRunner);

janpecha added a commit that referenced this pull request Dec 10, 2022
@janpecha
Copy link
Member

Implemented as bb195e3

@janpecha janpecha closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants