Open
Conversation
DwardEE
approved these changes
Aug 20, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good work on the diagram.
For WINDOWED FUNCTIONS Q1, your ROW_NUMBER() over all rows increments per row, not per market_date.
It's a small fix, so I'm considering the assignment complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code, creating additional tables, modifying tables.
What did you learn from the changes you have made?
That not all vendors had stock of their inventory.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I did not think of any other approaches as I was not aware of any.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had challenges with the JOIN functions which took the most time to correct.
How were these changes tested?
I tested multiple versions of the code until it worked.
A reference to a related issue in your repository (if applicable)
N/A
Checklist