Skip to content

Rename binary from serve to https-localhost#58

Closed
TimDaub wants to merge 1 commit intodaquinoaldo:masterfrom
TimDaub:master
Closed

Rename binary from serve to https-localhost#58
TimDaub wants to merge 1 commit intodaquinoaldo:masterfrom
TimDaub:master

Conversation

@TimDaub
Copy link
Copy Markdown

@TimDaub TimDaub commented Jan 11, 2021

Pull Request Details

Related Issue

Please, open an issue before a pull request. It will help in understanding better the PR aim.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation or my changes dont require it.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes (or the existing one were enough).
  • All new and existing tests passed.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e5c32e1 on TimDaub:master into 4031e95 on daquinoaldo:master.

@TimDaub
Copy link
Copy Markdown
Author

TimDaub commented Jan 15, 2021

FYI: I also noticed that technically there could be two entries in "bin":

{
  "bin": {
    "serve": "index.js"
    "https-localhost": "index.js"
  }
}

but anyways, I don't think having serve in it wouldn't solve #57

@daquinoaldo
Copy link
Copy Markdown
Owner

Yes, having an alias with https-localhost it's a good idea, but if we don't change serve the issue is not solved.

@daquinoaldo
Copy link
Copy Markdown
Owner

daquinoaldo commented Jan 24, 2021

Closing for the same reason as #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File exists: /usr/local/bin/serve

3 participants