fix: swap allowAbsurdFees for maxFeeRate for Dash Core v18#90
Merged
shumkov merged 2 commits intodashpay:masterfrom Sep 19, 2022
Merged
fix: swap allowAbsurdFees for maxFeeRate for Dash Core v18#90shumkov merged 2 commits intodashpay:masterfrom
shumkov merged 2 commits intodashpay:masterfrom
Conversation
thephez
reviewed
Sep 14, 2022
Author
|
This PR is incomplete. It took a few days for me to set up a full node to test (33gb of blocks and 50gb of indexes). Notes for follow up:
- sendRawTransaction: 'str bool bool',
+ sendRawTransaction: 'str float bool',Even after that change I still get: Error: "absurdly-high-fee, 383 > 373 (code 256). Code:-26"Can't figure out where it's coming from. |
Author
|
I updated this from feedback on discord that maxFeeRate was a float, but I'm pretty sure it's supposed to be an int. When I change from Also need to investigate |
Collaborator
|
@coolaj86 so we need one more PR? |
This was referenced Sep 22, 2022
Author
|
All related PRs have been opened. I've tested locally going over and under the maximum fee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback wanted: What should the default
maxFeeRatebe?Re: dashpay/insight-ui#75