1212
Added support for dat-store, fixed up extensions by RangerMauve · Pull Request #1091 · dat-ecosystem/dat · GitHub
Skip to content

Added support for dat-store, fixed up extensions#1091

Merged
RangerMauve merged 2 commits intomasterfrom
store
Apr 2, 2019
Merged

Added support for dat-store, fixed up extensions#1091
RangerMauve merged 2 commits intomasterfrom
store

Conversation

@RangerMauve
Copy link
Copy Markdown
Contributor

  • Fixes extensions not being able to show help messages
  • Fixes launching extensions on Windows (it needed to be spawned as .cmd)
  • Adds support for the dat-store extension

@RangerMauve RangerMauve requested a review from joehand April 2, 2019 19:04
Comment thread bin/cli.js
Copy link
Copy Markdown
Collaborator

@joehand joehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RangerMauve
Copy link
Copy Markdown
Contributor Author

Does this look good to merge? I'd like to add it to the draft of my Dat blog post.

@joehand
Copy link
Copy Markdown
Collaborator

joehand commented Apr 2, 2019

Yep!

@RangerMauve RangerMauve merged commit e974fd7 into master Apr 2, 2019
@RangerMauve
Copy link
Copy Markdown
Contributor Author

Would you mind publishing the release? I don't have 2FA enabled on NPM.

@joehand joehand deleted the store branch June 19, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants