Parse arbitrary exprs after "import" and "importStr"#153
Merged
lihaoyi-databricks merged 3 commits intodatabricks:masterfrom May 31, 2023
Merged
Parse arbitrary exprs after "import" and "importStr"#153lihaoyi-databricks merged 3 commits intodatabricks:masterfrom
lihaoyi-databricks merged 3 commits intodatabricks:masterfrom
Conversation
Fixes databricks#138 The spec is not very clear on this but this behavior is consistent with the C++ and Go implementations.
534157e to
f546c0b
Compare
Contributor
|
Is this still something you want to merge? Also, will this catch cases like: |
lihaoyi-databricks
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
The spec is not very clear on this but this behavior is consistent with the C++ and Go implementations.