Make Jsonnet std lib non-global#166
Merged
lihaoyi-databricks merged 3 commits intomasterfrom May 30, 2023
Merged
Conversation
Contributor
Author
|
Review by @szeiger |
szeiger
approved these changes
May 30, 2023
Collaborator
szeiger
left a comment
There was a problem hiding this comment.
I think in the longer term we should look into getting a clearer separation of official Jsonnet functions and custom extensions instead of putting non-standard functions into std.
Contributor
Author
|
Yeah this change would open up the possibility of defining custom |
Collaborator
|
What I meant is that we should put them into a separate object (e.g. |
This was referenced Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This serves two purposes:
We think we're seeing race conditions where the lazily-evaluated mutable state in the std lib
Val.Objis causing livelocks when evaluating Jsonnet in a multithreaded environment.This will allow whoever instantiates
sjsonnet.Interpreterto customize thestd.*, allowing people to inject their own functions. Useful if google/jsonnet has some new std lib functions that haven't been added to sjsonnet yet, or if you have some domain-specific functions you want to expose in your config