-
Notifications
You must be signed in to change notification settings - Fork 68
Fix parsing of object key starting with assert#169
Merged
lihaoyi-databricks merged 2 commits intomasterfrom Jun 2, 2023
Merged
Fix parsing of object key starting with assert#169lihaoyi-databricks merged 2 commits intomasterfrom
assert#169lihaoyi-databricks merged 2 commits intomasterfrom
Conversation
szeiger
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152 and #65. All the other places we parse keywords are followed by a
~~ breakto ensure the keyword ends there, so"assert"should as well.Added some tests to loop through all the keywords to make sure this behavior doesn't appear for any of the other ones, in the three distinct contexts I can think of where identifiers might appear (local variable declarations, expressions, and object keys)