Avoid generating unquoted octal-like strings to avoid parser bugs#183
Merged
lihaoyi-databricks merged 12 commits intomasterfrom Sep 8, 2023
Merged
Avoid generating unquoted octal-like strings to avoid parser bugs#183lihaoyi-databricks merged 12 commits intomasterfrom
lihaoyi-databricks merged 12 commits intomasterfrom
Conversation
--yaml-no-unquoted-string-literals flag to work around parser bugs
szeiger
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not every YAML parser distinguishes between unquoted string literals the same way:
This PR forces strings like
088579281390to be rendered as quoted'088579281390'. While this is not strictly necessary, there are several YAML parsers which mis-handle this kind of output, and so we ensure things are quoted to avoid triggering this edge case.Added a unit test that on master fails due to generation of non-quoted octal-like strings, and on this PR passes with all strings quoted