Merged
Conversation
juliagallucci
approved these changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Good! Your code executes without error and is well commented. One suggestion would be to make your code more concise when possible. For instance, you dont have to specify True/False for a conditional statement. See below for example of Part A written as 2 lines of code
def anagram_checker(word_a, word_b):
return sorted(word_a.lower()) == sorted(word_b.lower())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
For the 3rd scenario, it was hard to sort the order of the words for comparison, as the first letter of the word does not necessarily decides which word from each list should be compared. Then also the upper case also got in the way of sorting the word. So I googled a way of uppercase the list of words, separate the words into single letters, then sort letters for each word, then sort the order of list of letters. This way, the same indexed word from both lists can be compared.
How were these changes tested?
They were tested with both positive and negative tests, using different parameters, like different combination of words with different uppercased letters, or with different case-sensitive requirements.
A reference to a related issue in your repository (if applicable)
n/a
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist
Yes