Revert "Revert "submitting python first assignment""#3
Open
davidancor wants to merge 1 commit intomainfrom
Open
Revert "Revert "submitting python first assignment""#3davidancor wants to merge 1 commit intomainfrom
davidancor wants to merge 1 commit intomainfrom
Conversation
xindizhang
approved these changes
Dec 6, 2025
xindizhang
left a comment
There was a problem hiding this comment.
Thank you for addressing my comment. Excellent work! Your code is clean and well-written and your PR description is clear. Your assignment 1 is complete – no changes needed.
Just one minor tip for future improvement: It’s good practice to add comments or brief documentation to your code so it’s easier for you to review and debug later, and for teammates to understand quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2