Open
Conversation
tianyi21
approved these changes
Oct 28, 2025
tianyi21
left a comment
There was a problem hiding this comment.
Hi Duncan,
✅ You implemented the function to read and display a file.
✅ You completed the patient_summary() function to summarize a file.
✅ You implemented the detect_problems() function to check the file.
🎉 Your A2 is complete!
🎊 All your Python assessments are now complete. Thank you for your participation, and I wish you all the best for your future!
Thanks,
Tianyi [LS]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment 2
What did you learn from the changes you have made?
I was already familiar with for loops etc... but it did take me a minute to work out the difference between functions and methods.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I think for most of these they were pretty straightforward. I did experiment a bit with different methods for reading in the file until I found the shortest/simplest (at least in my view)
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had some issues with using the numpy functions before I realized I wasn't defining the axis.
How were these changes tested?
Tested in the jupyter notebook.
A reference to a related issue in your repository (if applicable)
Checklist