Skip to content
This repository was archived by the owner on Nov 14, 2017. It is now read-only.

Spam regulation and Kick command & fixed solution to use /externals/craft.net not ../craft.net#13

Open
tuomas56 wants to merge 6 commits intoddevault:masterfrom
tuomas56:master
Open

Spam regulation and Kick command & fixed solution to use /externals/craft.net not ../craft.net#13
tuomas56 wants to merge 6 commits intoddevault:masterfrom
tuomas56:master

Conversation

@tuomas56
Copy link
Copy Markdown

@tuomas56 tuomas56 commented Jun 2, 2013

Spam system:
you can only send a message 4 times in a row,
counter is reset when you send a different message

Kick command
only ops can kick
when you are kicked it shows "You were kicked by [player]" ([player] being the person who kicked you)
it also prints "[player] was kicked by [player]" to the server chat.

I have also fixed compile order and project dependencies location so that it will compile if you only fork PartyCraft.

kick limited to ops, if you say something four times in a row, you will
not be able to say that message again until you say something else.
I also fixed compile order and external project location (would not
compile unless you had also forked Craft.Net)
Comment thread PartyCraft/Commands/KickCommand.cs Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much whitespace here.

tuomas56 added 2 commits June 2, 2013 17:14
SpamController class now needs object reference, removed whitespace from
KickCommand.cs and create spamController object in Server.cs
changed spamController to internal so it doesn't give me errors about
accessibility and updated names for spamController.Init() on login and
spamController.Remove() on logout.
Comment thread PartyCraft.sln Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this back, please. Use MonoDevelop or SharpDevelop if you can't get Visual Studio.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remains a problem.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have fixed. sorry for taking so long with the other things.

On Tue, Jul 16, 2013 at 4:04 PM, Drew DeVault [email protected]:

In PartyCraft.sln:

@@ -1,25 +1,42 @@

Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 2012
+# Visual Studio Express 2012 for Windows Desktop

This remains a problem.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13/files#r5217878
.

@ddevault
Copy link
Copy Markdown
Owner

ddevault commented Jun 4, 2013

Take out the spam protection, I think that'd be better as a plugin.

@tuomas56 tuomas56 closed this Jun 22, 2013
@tuomas56 tuomas56 reopened this Jun 22, 2013
@tuomas56
Copy link
Copy Markdown
Author

Ok. Just editing.

@tuomas56 tuomas56 closed this Jun 22, 2013
@tuomas56 tuomas56 reopened this Jul 16, 2013
@tuomas56
Copy link
Copy Markdown
Author

Have taken out spamProtection and edited kickCommand

@ddevault
Copy link
Copy Markdown
Owner

I'll review and merge this later today.

@tuomas56
Copy link
Copy Markdown
Author

Thank you.

On Tue, Jul 16, 2013 at 5:05 PM, Drew DeVault [email protected]:

I'll review and merge this later today.


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-21052699
.

@ddevault
Copy link
Copy Markdown
Owner

Sorry this has been out there for so long. I need to do some serious reworking of PartyCraft to get it to fit well into the latest changes to Craft.Net, and I'll make sure this is included.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants