Skip to content

Add supports-color as optional peerDependency#709

Closed
jgierer12 wants to merge 1 commit intodebug-js:masterfrom
jgierer12:supports-color-optional-peer-dep
Closed

Add supports-color as optional peerDependency#709
jgierer12 wants to merge 1 commit intodebug-js:masterfrom
jgierer12:supports-color-optional-peer-dep

Conversation

@jgierer12
Copy link

@jgierer12 jgierer12 commented Jun 1, 2019 •
edited
Loading

This is the proper way to declare this type of dependency.

Note that if peerDependenciesMeta is not supported by the package
manager (yarn < 1.13 and npm) and supports-color is not installed, a warning will be
displayed.

See peerDependencies, peerDependenciesMeta.

Without this, Yarn PnP to throws an error when debug is in the dependency tree, since PnP is very strict about requireing packages that aren't declared as dependencies.

@jgierer12
Add supports-color as optional peerDependency
46b89a5 
This is the proper way to declare this type of dependency.

Note that if `peerDependenciesMeta` is not supported by the package
manager and `supports-color` is not installed, a warning will be
displayed.
@coveralls
Copy link

coveralls commented Jun 1, 2019

Coverage Status

Coverage remained the same at 87.692% when pulling 46b89a5 on jgierer12:supports-color-optional-peer-dep into 5c7c61d on visionmedia:master.

@eps1lon
Copy link

eps1lon commented Sep 6, 2019

Quick update that peerDependenciesMeta is implemented in [email protected], [email protected] but not yet bundled with node and pnpm@?

I'm currently not using this feature myself until node bundles [email protected]. If there are any concerns about this feature please let me know.

original RFC

@Qix- Qix- mentioned this pull request Nov 27, 2019
Closed
@arcanis
Copy link
Contributor

arcanis commented Nov 27, 2019 •
edited
Loading

Note that the situation changed since the last comment. The peerDependenciesMeta is supported by all modern package managers (at least 6 month old).

Additionally, listing peerDependenciesMeta is enough for the peer dependency to be inferred even without the peerDependencies field being set - providing a smooth adoption path even for older package managers.

CC @Qix-

@zypA13510 zypA13510 mentioned this pull request May 19, 2020
Merged
@Qix- Qix- closed this May 19, 2020
@Qix-
Copy link
Member

Qix- commented May 19, 2020

Published as 4.2.0 under the beta dist-tag. Please test and make sure nothing has broken for you before I send to latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgierer12 @coveralls @eps1lon @arcanis @Qix-