Skip to content

chore(docs): Document new IPs for allowlisting#322

Merged
m1so merged 1 commit intomainfrom
michalbaumgartner/blu-5665-document-new-public-ips
Feb 23, 2026
Merged

chore(docs): Document new IPs for allowlisting#322
m1so merged 1 commit intomainfrom
michalbaumgartner/blu-5665-document-new-public-ips

Conversation

@m1so
Copy link
Contributor

@m1so m1so commented Feb 23, 2026 •
edited by coderabbitai bot
Loading

also reformatted Snowflake SQL snippets to make them more readable (without horizontal scrolling) and fixed example for altering network policy

Summary by CodeRabbit

  • Documentation
    • Updated IP allowlist documentation with three additional IP addresses for enhanced connectivity configuration.

@m1so m1so requested a review from a team as a code owner February 23, 2026 14:23
@linear
Copy link

linear bot commented Feb 23, 2026

BLU-5665 Document new public IPs

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

  • docs/securing-connections.md: Appends three IPs (138.199.245.32, 138.199.245.36, 148.251.31.233) to the fixed Deepnote IP list.
  • docs/snowflake.md: Updates SQL examples. For ALTER NETWORK POLICY, switches from ARRAY_APPEND to ARRAY_CAT with ARRAY_DISTINCT to append and deduplicate IPs, adding the same three IPs. For CREATE NETWORK POLICY, replaces a literal tuple with a multi-line array/list construction including those IPs, aligning with the deduplicated approach.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Updates Docs ⚠️ Warning Documentation updated with three new IPs in securing-connections.md and snowflake.md, but ALTER NETWORK POLICY example uses invalid Snowflake syntax with ARRAY functions. Fix ALTER NETWORK POLICY SQL syntax to use parenthesized comma-separated IP list. Verify roadmap update in deepnote-internal private repo.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: documenting new IPs for allowlisting, which matches the changeset's primary objective of adding three new IP addresses to documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@m1so m1so enabled auto-merge (squash) February 23, 2026 14:25
@codecov
Copy link

codecov bot commented Feb 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.43%. Comparing base (0e8ac2f) to head (80d2d1e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files         114      114           
  Lines        6980     6980           
  Branches     1864     1864           
=======================================
  Hits         5824     5824           
  Misses       1156     1156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Artmann
Artmann approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@Artmann Artmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@m1so m1so merged commit f416207 into main Feb 23, 2026
20 of 21 checks passed
@m1so m1so deleted the michalbaumgartner/blu-5665-document-new-public-ips branch February 23, 2026 14:26
coderabbitai[bot]
coderabbitai bot requested changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/snowflake.md`:
- Around line 108-120: The ALTER NETWORK POLICY statement is using ARRAY
functions and bracket literals which Snowflake rejects; update the ALTER NETWORK
POLICY your_existing_policy SET ALLOWED_IP_LIST assignment to use a
parenthesized, comma-separated list of string literals (e.g., SET
ALLOWED_IP_LIST = ('ip1','ip2',...)) instead of ARRAY_CAT/ARRAY_DISTINCT or
[...] literals, and if you intended to append rather than replace first retrieve
the current entries via DESC NETWORK POLICY or
SNOWFLAKE.ACCOUNT_USAGE.NETWORK_POLICIES and include them in the new
parenthesized list passed to ALLOWED_IP_LIST.
ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e8ac2f and 80d2d1e.

📒 Files selected for processing (2)
  • docs/securing-connections.md
  • docs/snowflake.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saltenasl saltenasl saltenasl approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

+1 more reviewer

@Artmann Artmann Artmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m1so @Artmann @saltenasl