Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

packages/runtime-core/src/kernel-client.test.ts (1)

119-125: ⚠️ Potential issue | 🟡 Minor

Test verifies presence, not filtering behavior.

This confirms a WebSocket factory is passed but doesn't verify that v1.kernel.websocket.jupyter.org gets filtered out. The core fix remains unguarded.

Consider instantiating the factory and asserting the protocol is excluded:

it('WebSocket factory filters out binary protocol', async () => {
  await client.connect('http://localhost:8888')
  
  const callArg = mockMakeSettings.mock.calls[mockMakeSettings.mock.calls.length - 1][0]
  const WebSocketFactory = callArg.WebSocket as typeof WebSocket
  
  // Verify binary protocol is filtered from array
  const ws = new WebSocketFactory('ws://test', ['v1.kernel.websocket.jupyter.org', 'other'])
  // Would need to capture what super() received - alternatively test createJsonWebSocketFactory directly
})

Or export and unit test createJsonWebSocketFactory directly for cleaner assertions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/runtime-core/src/kernel-client.test.ts` around lines 119 - 125, The
test currently only checks that a WebSocket factory is passed (mockMakeSettings
call) but does not assert that the unwanted protocol
'v1.kernel.websocket.jupyter.org' is filtered; update the test to either (a)
instantiate the passed WebSocket factory from the last mockMakeSettings call
(inspect callArg.WebSocket) and wrap/spy the underlying WebSocket constructor to
capture the protocols array so you can assert the binary protocol is omitted, or
(b) export and unit-test the createJsonWebSocketFactory function directly and
assert that when given protocols including 'v1.kernel.websocket.jupyter.org' it
returns/constructs with that protocol removed; reference mockMakeSettings,
callArg.WebSocket and createJsonWebSocketFactory in the fix.

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

packages/runtime-core/src/kernel-client.test.ts (1)

120-125: ⚠️ Potential issue | 🟠 Major

Test the protocol filtering, not just function presence.

Line 123-Line 125 confirms only that WebSocket is a function. It still does not prove v1.kernel.websocket.jupyter.org is removed, so the Bun fix can regress silently.

♻️ Proposed test update

-    it('passes a WebSocket factory to server settings', async () => {
+    it('filters out Jupyter binary protocol from negotiated protocols', async () => {
+      const wsCtor = vi.fn()
+      vi.stubGlobal('WebSocket', wsCtor)
+
       await client.connect('http://localhost:8888')
 
-      const callArg = mockMakeSettings.mock.calls[mockMakeSettings.mock.calls.length - 1][0]
-      expect(callArg).toHaveProperty('WebSocket')
-      expect(typeof callArg.WebSocket).toBe('function')
+      const callArg = mockMakeSettings.mock.lastCall?.[0]
+      expect(callArg?.WebSocket).toEqual(expect.any(Function))
+
+      const protocols = ['v1.kernel.websocket.jupyter.org', 'json']
+      new (callArg!.WebSocket as typeof globalThis.WebSocket)('ws://localhost:8888/', protocols)
+
+      expect(wsCtor).toHaveBeenCalled()
+      const [, negotiatedProtocols] = wsCtor.mock.calls[0]
+      expect(negotiatedProtocols).toEqual(
+        expect.not.arrayContaining(['v1.kernel.websocket.jupyter.org'])
+      )
+      expect(negotiatedProtocols).toEqual(expect.arrayContaining(['json']))
+
+      vi.unstubAllGlobals()
     })

As per coding guidelines, "Create comprehensive tests for all new features using Vitest" and "Test edge cases, error handling, and special characters in test files".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/runtime-core/src/kernel-client.test.ts` around lines 120 - 125, The
test only checks that settings.WebSocket is a function but not that it filters
out the banned protocol; update the test to call the factory function returned
in mockMakeSettings (grabbed via mockMakeSettings.mock.calls[...] ->
callArg.WebSocket) with a protocols array that includes
'v1.kernel.websocket.jupyter.org' and verify the underlying WebSocket
constructor/spy receives a protocols array that does NOT contain
'v1.kernel.websocket.jupyter.org' (and still includes other protocols), ensuring
protocol filtering behavior is asserted rather than just function presence.

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.