Open
Conversation
xindizhang
approved these changes
Dec 3, 2025
There was a problem hiding this comment.
Your code meets the assignment requirements and is well-documented — great job! Your assignment 1 is complete – no changes needed.
Please see my suggestions for future improvement to make your code cleaner and more dfficient:
- You're missing a return statement in the final if block — it currently only prints the result.
- No need to convert strings to lists — strings are already iterable.
- You're using both
str.replace(...)andall(char in ...)to check for anagrams. This is redundant — choose one consistent strategy for clarity and efficiency. - Instead of
is_case_sensitive == False:, you can useif not is_case_sensitive:. In Python, booleans already evaluate directly in conditions. That way your code is cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment one tasks
What did you learn from the changes you have made?
Getting familiar with working with strings, For loops and nested If statement syntax
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I'm sure there's a way to create the anagram checker without a For loop so I will try and work on it!
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Figuring out how indentation works with if statements! I just did it by trial and error. Also figuring out how to deal with repeated letters in a word.
How were these changes tested?
Tested the anagram checker on different pairs of words.
A reference to a related issue in your repository (if applicable)
N/A
Checklist