Open
Conversation
Aditya-k-23
suggested changes
Dec 9, 2025
Aditya-k-23
left a comment
There was a problem hiding this comment.
Your code meets the some assignment requirements and but needs further improvement
Here are some suggestions:
- For Q1, you need to store the file contents in a variable using readlines and print the entire contents of the file using a for loop. In your current implementation, you have only printed the first line of the file.
- For Q2, the indentation is improper for both elif branches.
Please fix the above and resubmit your assignment for it to be considered complete.
Owner
Author
|
Hello @Aditya-k-23, thank you for the suggestions. I've made the changes, do I need to create another PR? |
Aditya-k-23
approved these changes
Dec 17, 2025
Aditya-k-23
left a comment
There was a problem hiding this comment.
Thank you for incorporating feedback, this looks good! Your assignment is complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code to address the assignment requirements.
What did you learn from the changes you have made?
Practicing with file IO, simple NumPy array functions
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
The given approach worked (I think!) so I didn't feel the need to try something else.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No challenges.
How were these changes tested?
Compared manual calculation of mean/max/min from the datasets to confirm expected results from the Python code
A reference to a related issue in your repository (if applicable)
None.
Checklist